api: Early-detect null bytes from Metadata.Marshaller #9781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
How about adding the same checks to
|
sanjaypujare
reviewed
Jan 3, 2023
Contributor
sanjaypujare
left a comment
sanjaypujare
left a comment
There was a problem hiding this comment.
Found 2 places where the check can potentially be added
Member
Author
|
I had seen both of those places and didn't care. The first will already NPE and the second is fairly safe. It would be good to fix the second to avoid needing to consider the case, and I might as well be consistent with the error message for the first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #9706