xds: implement XdsClient APIs for watching LDS/RDS resources individually #7470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidzcy
force-pushed
the
impl/implement_individual_lds_rds_watch_apis
branch
from
472087d to
016f871
Compare
Contributor
There was a problem hiding this comment.
Posted diff between XdsClientImpl and XdsClientImpl2 at 1323354 for convenience:
https://gist.github.com/dapengzhang0/0852cc0506fea3afbfd34bfdf9954fb8
dapengzhang0
reviewed
Oct 2, 2020
dapengzhang0
approved these changes
Oct 2, 2020
| new CancellationListener() { | ||
| @Override | ||
| public void cancelled(Context context) { | ||
| adsEnded.set(true); |
Contributor
There was a problem hiding this comment.
This adsEnded flag is weak because if retry happens there could be multiple streams created, as long as one of them is cancelled, this flag is true. (XdsClientImplTest1 has adsEnded.set(false))
Contributor
Author
There was a problem hiding this comment.
You are right. Added.
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
…ally (grpc#7470) Add XdsClient implementation of watching LDS/RDS resources, replacing the ConfigWatcher API. This makes LDS/RDS/CDS/EDS resource watchers work similarly. This change also cleans up XdsClientImpl's tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First take for replacing ConfigWatcher with LdsResourceWatcher and RdsResourceWatcher. The next take is #7469.
Effective changes should be for LDS/RDS protocols only. Tests for XdsClientImpl are cleaned up.