Add support for cross-compiling for aarch64 platform #6441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modified the building scripts to support cross compile grpc-java for aarch64 platform For #grpc/grpc-java/issues#6364
Contributor
Author
|
Hi @ejona86, I have updated this PR and now the Thanks a lot! |
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
reviewed
Dec 6, 2019
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Looks pretty close. Just some things that look unnecessary. I've started a Kokoro run, so you can see what the output looks like.
ejona86
reviewed
Dec 6, 2019
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
approved these changes
Dec 6, 2019
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Need to still wait for this last build to complete, but it looks like this will work.
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
added
the
TODO:backport
Member
|
@liusheng, thank you! |
ejona86
removed
the
TODO:backport
Contributor
Author
|
@ejona86 thanks a lot for changing and proposing this change :) |
Member
Contributor
Author
|
@ejona86 got it, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modified the building scripts to support cross compile
grpc-java for aarch64 platform
For #6364