netty: fix race in server channel startup and shutdown #2672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Jan 31, 2017
| // `channel` shutdown can race with `ch` initialization, so this is only safe to increment | ||
| // inside the lock. | ||
| eventLoopReferenceCounter.retain(); | ||
| ch.closeFuture().addListener(new ChannelFutureListener() { |
Member
There was a problem hiding this comment.
This addListener could be placed after the synchronized block, but I honestly don't care.
Contributor
Author
There was a problem hiding this comment.
I moved the whole chain.
carl-mastrangelo
force-pushed
the
nettyservernag
branch
from
13cafbe to
af3e906
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an expansion of 2292cbf