services: make reflection test able to re-root proto #2657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericgribkoff
approved these changes
Jan 26, 2017
Contributor
ericgribkoff
left a comment
ericgribkoff
left a comment
There was a problem hiding this comment.
LGTM, one minor comment on line break
| .setFileByFilename( | ||
| FILE_NAME_PREFIX | ||
| + "io/grpc/reflection/testing/" | ||
| + "dynamic_reflection_test_depth_two.proto") |
Contributor
There was a problem hiding this comment.
Does this string need to be split over two lines?
carl-mastrangelo
force-pushed
the
fnprefix
branch
from
975919e to
42c8953
Compare
ejona86
requested changes
Jan 26, 2017
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
What's with all the changes? It looks like this should be a 4 line PR. Are there other modifications other than whitespace changes for the rest of it?
Contributor
Author
|
I ran google-java-format on it. |
Member
How about no? File-wide reformatting is not okay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.