no reflection in InstantTimeProvider, fixes #11975 #11977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannanjgithub
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
approved these changes
Mar 25, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Yeah, this is probably the only way to get R8 to retain methods correctly.
ejona86
added
kokoro:run
kannanjgithub
approved these changes
Mar 26, 2025
Sangamesh1997
pushed a commit
to Sangamesh1997/grpc-java
that referenced
this pull request
Apr 3, 2025
|
The issue https://issuetracker.google.com/414711496 is actually caused by this reflection. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there is not need to use reflection in InstantTimeProvider.
if Instant class is present, then we can use normally.