xds: propagate audience from cluster resource in gcp auth filter #11972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm working on fixing the unit tests. Until then please take a look and provide suggestions/ improvements. |
ejona86
reviewed
Mar 21, 2025
ejona86
reviewed
Mar 25, 2025
ejona86
reviewed
Mar 25, 2025
ejona86
approved these changes
Mar 26, 2025
kannanjgithub
requested changes
Apr 2, 2025
Contributor
kannanjgithub
left a comment
kannanjgithub
left a comment
There was a problem hiding this comment.
Some minor comments.
kannanjgithub
requested changes
Apr 2, 2025
Contributor
kannanjgithub
left a comment
kannanjgithub
left a comment
There was a problem hiding this comment.
Forgot the catching runtime exception comment.
kannanjgithub
approved these changes
Apr 2, 2025
Sangamesh1997
pushed a commit
to Sangamesh1997/grpc-java
that referenced
this pull request
Apr 3, 2025
shivaspeaks
added a commit
to shivaspeaks/grpc-java
that referenced
this pull request
May 22, 2025
shivaspeaks
added a commit
that referenced
this pull request
May 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.