Skip to content

Conversation

@sergiitk
Copy link
Member

@sergiitk sergiitk commented Feb 28, 2024

xDS v2 support was dropped about a year ago, but the xds package still had a few xDS v2 usages. This PR:

  • Removes all leftover usages of xDS v2 classes in gprc-xds: 3438f2d, 83e6f0d
  • Removes all imported xDS v2 protos and their leaf dependencies: 9754d0b, c24b798
  • Removes xDS v2 generated services: 3d83fe3
  • Makes minor improvements to the xds import script output: 7997d32

Before

# Imported 154 protos.
❯ find . -iname "*xds*.jar" -exec du -h {} \; | col -x
13M     ./build/libs/grpc-xds-1.63.0-SNAPSHOT-original.jar
6.1M    ./build/libs/grpc-xds-1.63.0-SNAPSHOT-sources.jar
388K    ./build/libs/grpc-xds-1.63.0-SNAPSHOT-javadoc.jar
14M     ./build/libs/grpc-xds-1.63.0-SNAPSHOT.jar

After

# Imported 86 protos.
❯ find . -iname "*xds*.jar" -exec du -h {} \; | col -x
9.1M    ./build/libs/grpc-xds-1.63.0-SNAPSHOT-original.jar
4.1M    ./build/libs/grpc-xds-1.63.0-SNAPSHOT-sources.jar
388K    ./build/libs/grpc-xds-1.63.0-SNAPSHOT-javadoc.jar
9.1M    ./build/libs/grpc-xds-1.63.0-SNAPSHOT.jar

Reduction:

  • Number of protos: 44%
  • Jar size: 35%

@sergiitk sergiitk force-pushed the delete-xds-v2 branch 2 times, most recently from 8f3244b to edbdc0c Compare February 28, 2024 22:12
@sergiitk sergiitk requested a review from ejona86 February 29, 2024 00:46
@sergiitk sergiitk marked this pull request as ready for review February 29, 2024 07:23
@sergiitk sergiitk merged commit feab4e5 into grpc:master Feb 29, 2024
@sergiitk sergiitk deleted the delete-xds-v2 branch February 29, 2024 18:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants