Skip to content

Conversation

@temawi
Copy link
Contributor

@temawi temawi commented Jan 19, 2024

Fixes: #10840

@temawi temawi requested review from ejona86 and jdcormie January 19, 2024 19:16
@jdcormie
Copy link
Member

Is this going to import into google3 without test failures?

@temawi
Copy link
Contributor Author

temawi commented Feb 21, 2024

I made a test CL (608784097) with this change and both presubmit as well as a sample tap_presubmit both pass for it.

@jdcormie, anything else you would suggest to look for breakages?

@temawi
Copy link
Contributor Author

temawi commented Feb 28, 2024

A full internal global presubmit build did not indicate issues with this change so I will go ahead and merge.

@temawi temawi merged commit ce2adcc into grpc:master Feb 28, 2024
@temawi temawi deleted the binder-api-annotations branch February 28, 2024 16:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

binder: We call SDK 30's bindServiceAsUser() and SDK 26's bindDeviceAdminServiceAsUser() methods without a runtime check

2 participants