OkHttpTransportTest earlyServerClose_serverFailure_withClientCancelOnListenerClosed is flaky

[sanjaypujare]

Please answer these questions before submitting your issue.

What version of gRPC are you using?

latest -> SNAPSHOT

What did you expect to see?

All tests should pass. Instead I see this failure more than once and it seems to be a flaky test:

Task :grpc-okhttp:test
io.grpc.okhttp.OkHttpTransportTest > earlyServerClose_serverFailure_withClientCancelOnListenerClosed FAILED
java.lang.AssertionError: Timed out waiting for server stream

build output:
https://source.cloud.google.com/results/invocations/3bc8b484-55e9-4e11-9476-c481f3dc1661/targets/grpc%2Fjava%2Fpresubmit%2Fmacos/log

[ejona86]

https://source.cloud.google.com/results/invocations/e3f8fd48-5ff4-40c8-b457-532aca2f6f16 (macos)

io.grpc.okhttp.OkHttpTransportTest > earlyServerClose_serverFailure_withClientCancelOnListenerClosed FAILED
    java.lang.AssertionError: Timed out waiting for server stream

[ejona86]

The failure seems to be in takeListenerOrFail. There doesn't look to be anything special about this test. All the TransportTests do basically the same boilerplate. The test is failing after 1 second.

[ejona86]

https://source.cloud.google.com/results/invocations/a0393fd2-9968-49b2-9512-01fe23c6f5fc/targets (macos)

[ejona86]

Oh, wait. Not takeListenerOrFail(), but takeStreamOrFail(). This may be a legitimate failure, since that test was added because of a race in InProcess transport. Maybe OkHttp has the same problem.

[ejona86]

https://source.cloud.google.com/results/invocations/1598a29c-e806-448b-bdb3-b72650072436/log (macos)

[ejona86]

https://source.cloud.google.com/results/invocations/9da67357-906e-4752-b9cb-1cd6cbd0cdb7/log (macos)

[creamsoup]

https://source.cloud.google.com/results/invocations/e1b1fc9a-321c-481b-8ebc-b1c486deeb3c (macos)