-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Open
Description
gRFC A89 Backend Service Metric Label has a different implementation approach dependent on whether this gRFC has been implemented. If A89 was implemented before this gRFC, then backend service plumbing needs to change to go through the cds policy instead of the xds_cluster_impl policy, as documented in A89.
It doesn't appear this change was done:
| args.getPickDetailsConsumer().addOptionalLabel("grpc.lb.backend_service", cluster); |
grpc-java/xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java
Lines 156 to 162 in 096c4d9
| childSwitchLb.handleResolvedAddresses( | |
| resolvedAddresses.toBuilder() | |
| .setAttributes(attributes.toBuilder() | |
| .set(NameResolver.ATTR_BACKEND_SERVICE, cluster) | |
| .build()) | |
| .setLoadBalancingPolicyConfig(config.childConfig) | |
| .build()); |