Skip to content

Backend Service Metric implementation should change for A75 Aggregate Cluster Fixes #12431

@ejona86

Description

@ejona86

https://github.com/grpc/proposal/blob/master/A75-xds-aggregate-cluster-behavior-fixes.md#changes-to-backend-service-metric-label-plumbing

gRFC A89 Backend Service Metric Label has a different implementation approach dependent on whether this gRFC has been implemented. If A89 was implemented before this gRFC, then backend service plumbing needs to change to go through the cds policy instead of the xds_cluster_impl policy, as documented in A89.

It doesn't appear this change was done:

args.getPickDetailsConsumer().addOptionalLabel("grpc.lb.backend_service", cluster);

childSwitchLb.handleResolvedAddresses(
resolvedAddresses.toBuilder()
.setAttributes(attributes.toBuilder()
.set(NameResolver.ATTR_BACKEND_SERVICE, cluster)
.build())
.setLoadBalancingPolicyConfig(config.childConfig)
.build());

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions