Skip to content

Conversation

@eshitachandwani
Copy link
Member

@eshitachandwani eshitachandwani commented May 23, 2025

Original PR: #8329
Related Issue: #8327

RELEASE NOTES:

  • client: restore support for NO_PROXY environment variable when connecting to locally-resolved addresses. This fixes a regression and restores historical grpc-go behavior (use case 2 from gRFC A1 ).

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.25%. Comparing base (3b5fa74) to head (531df95).
Report is 1 commits behind head on v1.72.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.72.x    #8353      +/-   ##
===========================================
+ Coverage    82.01%   82.25%   +0.23%     
===========================================
  Files          412      412              
  Lines        40382    40396      +14     
===========================================
+ Hits         33118    33226     +108     
+ Misses        5894     5821      -73     
+ Partials      1370     1349      -21     
Files with missing lines Coverage Δ
.../resolver/delegatingresolver/delegatingresolver.go 86.42% <100.00%> (+0.91%) ⬆️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eshitachandwani eshitachandwani merged commit eef8c9c into grpc:v1.72.x May 24, 2025
27 of 33 checks passed
@eshitachandwani eshitachandwani deleted the upstream-v1.72.x branch August 22, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants