Skip to content

Conversation

@arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Sep 17, 2024

Original PR: #7595

RELEASE NOTES: N/A

@arjan-bal arjan-bal added this to the 1.67 Release milestone Sep 17, 2024
@arjan-bal arjan-bal added the Type: Dependencies Updating/adding/removing dependencies label Sep 17, 2024
@codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (3ffb98b) to head (f7c303a).
Report is 1 commits behind head on v1.67.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.67.x    #7637      +/-   ##
===========================================
+ Coverage    81.87%   81.92%   +0.04%     
===========================================
  Files          361      361              
  Lines        27813    27816       +3     
===========================================
+ Hits         22773    22788      +15     
+ Misses        3843     3839       -4     
+ Partials      1197     1189       -8     
Files with missing lines Coverage Δ
mem/buffer_slice.go 96.20% <ø> (ø)

... and 37 files with indirect coverage changes

@purnesh42H
Copy link
Contributor

I think you still have to add the same release notes? LGTM otherwise

@arjan-bal
Copy link
Contributor Author

arjan-bal commented Sep 17, 2024

I think you still have to add the same release notes? LGTM otherwise

Since the change is already present in the latest release (1.66.2), I don't think we need to mention it in the release notes for 1.67. Confirming with other maintainers.

@arjan-bal arjan-bal changed the base branch from master to v1.67.x September 17, 2024 08:19
@arjan-bal arjan-bal changed the base branch from v1.67.x to master September 17, 2024 08:20
@arjan-bal arjan-bal changed the base branch from master to v1.67.x September 17, 2024 08:20
@arjan-bal arjan-bal merged commit 3c3a025 into grpc:v1.67.x Sep 17, 2024
1 check passed
@arjan-bal arjan-bal deleted the cherrypick/7595-remove-flate branch September 17, 2024 08:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: Dependencies Updating/adding/removing dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants