Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 5, 2023

See grpc/grpc#33878 (comment)

Generated code can pass in a null handler. Update Grpc.Core.Api annotations to match reality.

This isn't a breaking change. If a library inherits from ServiceBinderBase and has nullable annotations enabled, it will get a warning to prompt the developer to update the overloads to include ?. This is standard behavior when changing nullable annotations. There is no impact on runtime behavior.

@JamesNK JamesNK merged commit 91130a7 into grpc:master Sep 5, 2023
@JamesNK JamesNK deleted the jamesnk/nullable-handler branch September 5, 2023 13:51
oguzhand95 referenced this pull request in cerbos/cerbos-sdk-net Oct 25, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [Grpc.Net.Client](https://togithub.com/grpc/grpc-dotnet) | `2.57.0` ->
`2.58.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Grpc.Net.Client/2.58.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Grpc.Net.Client/2.58.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Grpc.Net.Client/2.57.0/2.58.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Grpc.Net.Client/2.57.0/2.58.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary>

###
[`v2.58.0`](https://togithub.com/grpc/grpc-dotnet/releases/tag/v2.58.0)

#### What's Changed

- Start 2.58 development cycle. by
[@&#8203;jtattermusch](https://togithub.com/jtattermusch) in
[https://github.com/grpc/grpc-dotnet/pull/2267](https://togithub.com/grpc/grpc-dotnet/pull/2267)
- Update ServiceBinderBase.AddMethod annotations to allow null handler
by [@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2270](https://togithub.com/grpc/grpc-dotnet/pull/2270)
- Add request and channel to call debugging by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2271](https://togithub.com/grpc/grpc-dotnet/pull/2271)
- Support disabling load balancing with SocketsHttpHandler.Properties by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2274](https://togithub.com/grpc/grpc-dotnet/pull/2274)
- Remove netstandard1.5 from some projects by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2279](https://togithub.com/grpc/grpc-dotnet/pull/2279)
- Add debugger display to Status by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2281](https://togithub.com/grpc/grpc-dotnet/pull/2281)
- Fix detecting inherited WinHttpHandler by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2288](https://togithub.com/grpc/grpc-dotnet/pull/2288)
- Dispose socket after connection failure by
[@&#8203;JamesNK](https://togithub.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2287](https://togithub.com/grpc/grpc-dotnet/pull/2287)
- Bump GrpcToolsPackageVersion to 2.58.0 by
[@&#8203;apolcyn](https://togithub.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2290](https://togithub.com/grpc/grpc-dotnet/pull/2290)
- Bump version to pre1 on 2.58 branch by
[@&#8203;apolcyn](https://togithub.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2291](https://togithub.com/grpc/grpc-dotnet/pull/2291)
- Update v2.58.x branch to 2.58.0 by
[@&#8203;apolcyn](https://togithub.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2299](https://togithub.com/grpc/grpc-dotnet/pull/2299)

**Full Changelog**:
grpc/grpc-dotnet@v2.57.0...v2.58.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cerbos/cerbos-sdk-net).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Oğuzhan Durgun <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Oğuzhan Durgun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants