Skip to content

Use PoolingAsyncValueTaskMethodBuilder on ReadStreamMessageAsync method #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2022
Merged

Use PoolingAsyncValueTaskMethodBuilder on ReadStreamMessageAsync method #1850

merged 2 commits into from
Aug 18, 2022

Conversation

mayuki
Copy link
Contributor

@mayuki mayuki commented Aug 18, 2022

Use PoolingAsyncValueTaskMethodBuilder on ReadStreamMessageAsync method to reduce allocations per streaming-message read.

image
image

dotnet run -c Release -p .\perf\benchmarkapps\GrpcClient\ -- -u http://localhost:5000 -c 10 --streams 50 -s pingpongstreaming -p h2c --grpcClientType grpcnetclient

JamesNK
JamesNK reviewed Aug 18, 2022
View reviewed changes
@mayuki @JamesNK
Fix indentation
7a8192d 
Co-authored-by: James Newton-King <[email protected]>
@JamesNK JamesNK merged commit 77ae8af into grpc:master Aug 18, 2022
@JamesNK
Copy link
Member

JamesNK commented Aug 18, 2022

Thanks!

@mayuki mayuki deleted the UsePoolingAsyncValueTaskMethodBuilder branch August 18, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesNK JamesNK JamesNK approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mayuki @JamesNK