Update solution to .NET 7 #1803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
force-pushed
the
jamesnk/net7
branch
3 times, most recently
from
21fb3f6 to
3ae6a3c
Compare
There was a problem hiding this comment.
Left a few comments. I'd also like @captainsafia to review.
jtattermusch
approved these changes
Aug 24, 2022
JamesNK
requested review from
BrennanConroy,
brunolins16,
captainsafia and
halter73
captainsafia
approved these changes
Aug 27, 2022
| <PropertyGroup> | ||
| <TargetFrameworks Condition="'$(LatestFramework)'!='true'">net6.0</TargetFrameworks> | ||
| <TargetFrameworks Condition="'$(LatestFramework)'=='true'">net6.0</TargetFrameworks> | ||
| <TargetFrameworks Condition="'$(LatestFramework)'!='true'">net7.0</TargetFrameworks> |
There was a problem hiding this comment.
Not directly related to this change, but why are two different conditions needed here?
There was a problem hiding this comment.
Interop tests are also run from grpc/grpc repo, and may specify a different framework.
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="$([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), 5.0))"> | ||
| <ItemGroup Condition="'$(TargetFramework)' == 'net5.0' OR '$(TargetFramework)' == 'net6.0' OR '$(TargetFramework)' == 'net7.0'"> |
There was a problem hiding this comment.
Any reason we're no longer VersionGreaterThanOrEquals? It's a bit more future-proof.
There was a problem hiding this comment.
I couldn't get it to work after adding net7.0 target 🤷
Yes. Grpc.AspNetCore is a metapackage and doesn't have a DLL itself. Adding this file keeps the build happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.