Skip to content

Split AsyncResolver out of Resolver #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2022
Merged

Split AsyncResolver out of Resolver #1573

merged 1 commit into from
Jan 19, 2022

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Jan 18, 2022 •
edited
Loading

Combining async logic into resolver, which doesn't necessarily use it, was identified as a problem in proposal review.

This change simplifies Resolver and moves async specific logic into AsyncResolver.

@JamesNK JamesNK requested a review from captainsafia January 18, 2022 23:56
@JamesNK JamesNK force-pushed the jamesnk/asyncresolver branch from 412cedc to 947db20 Compare January 19, 2022 08:39
@JamesNK JamesNK merged commit 687fbb4 into grpc:master Jan 19, 2022
@JamesNK JamesNK deleted the jamesnk/asyncresolver branch January 19, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@captainsafia captainsafia captainsafia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JamesNK @captainsafia