Fix load balancing subchannel compare and dispose error #1554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
commented
Jan 5, 2022
Comment on lines
+96
to
+99
| if (!_disposed) | ||
| { | ||
| _socketConnectedTimer.Change(TimeSpan.Zero, TimeSpan.Zero); | ||
| } |
There was a problem hiding this comment.
Guard against error if the transport is disconnected after it disposed.
JamesNK
commented
Jan 5, 2022
| { | ||
| var s = addressSubchannels[i]; | ||
| if (Equals(s.Address, address)) | ||
| if (Equals(s.Address.EndPoint, address.EndPoint)) |
There was a problem hiding this comment.
Compare the addresses endpoints to get subchannel reuse.
captainsafia
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression in 2.42.0 related to not correctly comparing subchannel addresses. The regression results in subchannels being recreated each time a resolver returns new addresses. Correct behavior is to recognize that a subchannel with an address already exists and continue to use it.
Note that most changes are related to logging. I noticed this when updating container example to use latest version and added more logging to help follow logic.
Should be backported to the 2.42.0 branch before the final version is released.