Log BalancerAddress instead of DnsEndPoint in load balancing #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Task<(Subchannel Subchannel, DnsEndPoint Address, Action<CompleteContext> OnComplete)> | ||
| #endif | ||
| PickAsync(PickContext context, bool waitForReady, CancellationToken cancellationToken) | ||
| public async ValueTask<(Subchannel Subchannel, BalancerAddress Address, Action<CompletionContext> OnComplete)> PickAsync(PickContext context, bool waitForReady, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Why is it OK to remove the if-def here?
There was a problem hiding this comment.
Originally I wrote this code to support netstandard2.0. It ended up being net5.0 or later. This is an unused ifdef that didn't get removed.
| /// </summary> | ||
| internal class SocketConnectivitySubchannelTransport : ISubchannelTransport, IDisposable | ||
| { | ||
| internal record struct ActiveStream(BalancerAddress Address, Socket Socket, Stream? Stream); |
There was a problem hiding this comment.
Nice use of record structs here!
There was a problem hiding this comment.
Friendship ended with tuples.
Now record structs is my best friend.
captainsafia
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log
BalancerAddressinstead ofDnsEndPointbecause it has a more friendly ToStringBefore:
After: