DNS resolver fix port usage #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes looks good to me 👍 |
JamesNK
force-pushed
the
vasicvuk-master
branch
from
f1b609e to
1533bb8
Compare
JamesNK
force-pushed
the
vasicvuk-master
branch
2 times, most recently
from
c085d0e to
e50eeee
Compare
captainsafia
approved these changes
Nov 16, 2021
| { | ||
| throw new ArgumentException($"Address '{address.OriginalString}' doesn't have a host. Address should include a scheme, host, and optional port. For example, 'https://localhost:5001'."); | ||
| } | ||
| ResolveCredentials(channelOptions, out _isSecure, out _callCredentials); |
JamesNK
force-pushed
the
vasicvuk-master
branch
from
2cfb684 to
b6ee3fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1482
Replaces #1489
@vasicvuk