Add support for per-address attributes #1472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
reviewed
Nov 8, 2021
There was a problem hiding this comment.
Should usage of DnsEndpoint directly in the samples be updated as well? I think it only happens in https://github.com/grpc/grpc-dotnet/blob/master/examples/Container/Frontend/Pages/FetchData.razor#L139.
The samples use a NuGet package and so will wait until the package version is updated. |
captainsafia
approved these changes
Nov 8, 2021
JamesNK
force-pushed
the
jamesnk/addressmetadata
branch
from
d47ac2a to
17405aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback from load balancing proposal review.
Addresses have changed from DnsEndPoint to BalancerAddress. This allows an address to have attributes (aka metadata).