Client handle server cancellation for deadline #1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
force-pushed
the
jamesnk/protocolerror
branch
from
8a4714b to
c2963e6
Compare
| } | ||
|
|
||
| status = s; | ||
| resolvedException = CreateRpcException(s); |
There was a problem hiding this comment.
Suggested change
| resolvedException = CreateRpcException(s); | |
| resolvedException = CreateRpcException(status); |
Nit: reads a little clearer although there's no functional difference.
There was a problem hiding this comment.
s is used here because status is nullable.
| } | ||
| #endif | ||
|
|
||
| public static int IndexOf(string s, char value, StringComparison comparisonType) |
There was a problem hiding this comment.
Ooooooh! Didn't realize we had this suite of compat helpers. I was wondering how we managed different warnings for each target in the build.
There was a problem hiding this comment.
If a method is only used once then the #ifdef is left inline. If a method is used multiple times then it makes sense to centralize it here.
JamesNK
commented
Sep 21, 2021
|
@captainsafia Additional feedback or approval so this can be merged? 🙏 |
JamesNK
force-pushed
the
jamesnk/protocolerror
branch
from
af0277b to
5e5f74f
Compare
JamesNK
force-pushed
the
jamesnk/protocolerror
branch
from
5e5f74f to
db3e63c
Compare
captainsafia
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1214
Handle the situation where the server exceeds deadline and sends RST_STREAM with status CANCELLED to the client, and the client receives it before its local timer executes.