-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: Use summary/description
instead of title for field comments in openapi
gen
#5759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add model_v1_book_name_body.go and model_v1_book_name_body_1.go - These files were generated as part of the comment processing changes - Required to pass Bazel gazelle consistency check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the correct version of swagger-codegen, see CONTRIBUTING.md. We should probably update it but not as part of this PR please.
2.4.47-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this changed?
@@ -5070,8 +5070,7 @@ | |||
"readOnly": true | |||
} | |||
}, | |||
"description": "The book's `name` field is used to identify the book to be updated.\nFormat: publishers/{publisher}/books/{book}", | |||
"title": "The book to update.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the title disappeared, was that intentional?
sorry @johanbrandhorst there was an issue with the swagger version in my system and because of that more code was pushed i will update it accordingly |
References to other Issues or PRs
Fixes: #3381
Have you read the Contributing Guidelines?
Brief description of what is fixed or changed
Other comments