Zap custom jsonpb to allow optional gogo JSONPb serialization #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a POC, just to ask if anyone would be interested on it.
Basically it allows me to do:
On my service, so then I can get proper payload logging with gogo types, such as *time.Time when using
gogoproto.stdtime = true. In other words, it avoids this bug: gogo/protobuf#212Since this is
go-grpc-middleware, I guess as much compatibility withgogoas possible is desirable?Let me know if this is interesting and if so, what should I change to make it acceptable to merge (maybe the same for Logrus logger, which would be trivial? Perhaps not import the
runtime.JSONPbMarshaler fromgrpc-gatewayto avoid that extra dependency, but have our own version?).Thanks!