Skip to content
This repository was archived by the owner on Jan 31, 2025. It is now read-only.

Maintenance: update container images to include Alpine v3.19.1 and Grocy v4.2.0 #243

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Maintenance: update container images to include Alpine v3.19.1 and Grocy v4.2.0 #243

merged 2 commits into from
Apr 19, 2024

Conversation

jayaddison
Copy link
Contributor

It didn't seem straightforward to upgrade the php82-* packages to use php83-* on Alpine yet; that upgrade is not included here.

@berrnd
Copy link
Member

berrnd commented Apr 19, 2024

Hi @jayaddison, I still don't have that much clue about that all here, but so far it looks fine to me, at least on Grocy side nothing has changed about dependencies and such between those two mentioned versions.

So I'm just going to merge this, if creating a release is just creating a tag I could also do that.

If you want to have the permissions here again to do that yourself, just let me know.

Thanks!

@berrnd berrnd merged commit a8e9627 into grocy:main Apr 19, 2024
@jayaddison jayaddison deleted the maintenance/alpine-3.19.1-grocy-4.2.0 branch April 19, 2024 10:51
@jayaddison
Copy link
Contributor Author

Thanks @berrnd!

So I'm just going to merge this, if creating a release is just creating a tag I could also do that.

If you want to have the permissions here again to do that yourself, just let me know.

I think this is a one-off update for now, so I won't ask for permissions myself; I can describe what the steps should be to create the release, though:

  • Configuring the GitHub DOCKERHUB_USERNAME and DOCKERHUB_TOKEN values so that the container publication steps can proceed.
  • Tagging a release commit - v4.2.0-1 in this case (the number at the end is a revision, that can increment if container-related changes are made for the v4.2.0 version of Grocy).

No requirement / hurry to do that; I thought it could be worth keeping the containers relatively up-to-date though.

@berrnd
Copy link
Member

berrnd commented Apr 19, 2024

Thanks for the hints. Added the required secrets (using my account) to the repo again, from what I can see it has worked.

https://github.com/grocy/grocy-docker/releases/tag/v4.2.0-1

https://github.com/grocy/grocy-docker/actions/runs/8754052880

@jayaddison
Copy link
Contributor Author

You're welcome - those and the resulting container images look good to me 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants