Change logging API from push to pull #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylane
force-pushed
the
sylane/add-exp-backoff
branch
from
4bca5c8 to
ab2ab04
Compare
sylane
force-pushed
the
sylane/log-pull
branch
from
f9e956d to
f3b069c
Compare
sylane
force-pushed
the
sylane/log-pull
branch
2 times, most recently
from
3afd8b2 to
4a8e375
Compare
|
You should have left the |
I rebased on top of the changes of the exponential backoff PR, so there is not much I could do, could I ? |
|
Maybe I got confused with another PR, yeah do not worry. |
sylane
force-pushed
the
sylane/log-pull
branch
from
4a8e375 to
9971a34
Compare
sylane
force-pushed
the
sylane/add-exp-backoff
branch
from
ba0f06f to
ee158fc
Compare
sylane
force-pushed
the
sylane/log-pull
branch
from
9971a34 to
e1ceffa
Compare
GwendalLaurent
approved these changes
Feb 24, 2025
GwendalLaurent
approved these changes
Feb 25, 2025
ziopio
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
grisp_connect_log_server.erlwas renamedgrisp_connect_log.erland a lot of the code remained unchanged, but git is not recognising the rename because there is too much differences (all the gen_server stuff got removed).