Added in deep compare option for bind and documented bind feature

[kjlubick]

First off, thanks for making a great localstorage module. I especially liked that it basically worked with everything, arrays and all, out of the box.

I had a complicated array structure that I wanted to store and as per http://stackoverflow.com/questions/14712089/how-to-deep-watch-an-array-in-angularjs
the advice was to use $watch instead of $watchCollection to deal with the deep comparision that I needed.

It's a relatively small change and I hope my documentation on bind is helpful to others as well.

[a8m]

@kjlubick , Thanks.
please add test(s).

[kjlubick]

Added a test. Is that sufficient?

[a8m]

@kjlubick would you please just merge these 4 commits into only one? thanks.

[kjlubick]

Couldn't do it in one because of the two merge conflicts.

[kjlubick]

Ready to merge

[a8m]

I think we should always use $watch(..., ..., true) instead of $watchCollection.
Because when we bind a non-primitive value we actually want tס do deep comparison.
@grevory What do you think ?

@kjlubick I think it's kinda messy to do something like that:
ls.bind($scope, 'key', null, 'key', true) instead of ls.bind($scope, 'key')
I dunno, 5 arguments it's too much for me.

[kjlubick]

5 args is a bit much, I agree. I didn't make it default because the angularjs docs warned of a performance hit - but if it's not doing what we want anyway than we don't have too much of a choice.

[a8m]

@kjlubick , we can go this way:

$scope.$watch(key, function(newVal) {
  //...
}, isObject($scope[key]));

so, if it's primitive value, we comparing for reference equality. so actually it really cheaper.

[grevory]

I like it
On Oct 11, 2014 5:00 PM, "Ariel Mashraki" [email protected] wrote:

@kjlubick https://github.com/kjlubick , we can go this way:

$scope.$watch(key, function(newVal) {
//...}, isObject($scope[key]));

so, if it's primitive value, we comparing for reference equality. so
actually it really cheaper.

—
Reply to this email directly or view it on GitHub
#144 (comment)
.