Storing a number converts it into a string

[skatenerd]

localStorageService.add("wat", 99)
//=> true
localStorageService.get("wat")
//=>"99"

[nmehta6]

local storage doesn't store values by type. It is simply a string key,value pair store.

Trying the following in chrome's console yields the same results.

window.localStorage.setItem('wat', 11)
window.localStorage.getItem('wat')
// => "11"

But I think that it would be a great idea to implement some support for primitive javascript types here.

[skatenerd]

This is confusing to me, because if you store an object, you get an object back. If you store this, for example: localStorageService.add("an-object", {n: 99})

Then, the inner number (99) doesn't get converted.

I guess I'm struggling to understand when the object will come back unchanged, and when it will come back with some parts turned into a string.

[grevory]

That's true. Someone did a PR to maintain the type of Object. We could add it in for Number as well.

[skatenerd]

Perhaps we could just serialize/deserialize everything?

[a8m]

@skatenerd @nmehta6 @grevory , see: Commit 44575f4- test spec

[deweydb]

Please excuse my ignorance on how these things work, but does the above committed test spec imply that there are plans to return ints as ints instead of strings?

[a8m]

@deweydb that's right, If you save a Number, you get a Number, not a String.

[deweydb]

Strange, I am still having ints being converted into strings in Chrome. I will produce an example later today and post it.

[a8m]

@deweydb Which version are you using currently?