fix(alsa): Don't leak alsactl monitor process #2220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was found when alsactl was repeatedly failing due to a missing device causing a number of alsactl processes to be running. This PR uses tokio's kill_on_drop and an added the process handle to a field in the device. I have not checked the rest of the code base for similar issues but at least after this PR alsa is fixed. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was found when alsactl was repeatedly failing due to a missing device causing a number of alsactl processes to be running.
This PR uses tokio's kill_on_drop and an added the process handle to a field in the device. I have not checked the rest of the code base for similar issues but at least after this PR alsa is fixed. :)
https://docs.rs/tokio/latest/tokio/process/struct.Command.html#method.kill_on_drop