Skip to content

Exclude read_only fields from input #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2020
Merged

Exclude read_only fields from input #882

merged 1 commit into from
Feb 23, 2020

Conversation

knabben
Copy link
Contributor

@knabben knabben commented Feb 21, 2020

The field filtering exists only for write_only in Output, this PR adds the opposite, read_only not showing in Input.

@knabben knabben requested a review from syrusakbary February 21, 2020 13:38
zbyte64
zbyte64 approved these changes Feb 21, 2020
View reviewed changes
Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enhancement 👍

jkimbo
jkimbo approved these changes Feb 23, 2020
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @knabben

@jkimbo jkimbo merged commit a12fc92 into graphql-python:master Feb 23, 2020
@jarcoal jarcoal mentioned this pull request May 23, 2020
Open
@CBuiVNG CBuiVNG mentioned this pull request Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbyte64 zbyte64 zbyte64 approved these changes

@jkimbo jkimbo jkimbo approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

+1 more reviewer

@alexantoniomoran alexantoniomoran alexantoniomoran approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knabben @zbyte64 @jkimbo @alexantoniomoran