fix: preserve sslrootcert when rewriting URLs #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, it looks like as a side effect of
makeRootDatabaseConnectionString()passing throughpg-connection-stringis that it fails to preserve some more complex connection string parameters, for instancesslrootcert. When that option is specified, it actually loads the certificate data, soparsed.sslbecomes{ca: '...'}rather thantrue.This means that when
makeRootDatabaseConnectionString()converts it back into a connection string, it adds?ssl=%5Bobject%20Object%5D.This PR switches to use the
urlmodule to just swap out the pathname, which in theory should be less disruptive than attempting to handle every possible connection parameter, as it preserves the connection URL that the user has provided (as a plus, this removes the// TODO: factor in other connection parameter). I'm not 100% familiar with why this was the way it was before, so I may be missing something, but hopefully this is more robust.There are two commits in this PR, one to add a failing test, and one to modify
makeRootDatabaseConnectionString(). I'm opening the PR with only the first so that Travis CI will start a build, then I'll push the 2nd.