Skip to content

Fix GraphiQL v0.9.3 #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2017
Merged

Fix GraphiQL v0.9.3 #410

merged 4 commits into from
Mar 26, 2017

Conversation

calebmer
Copy link
Collaborator

When working on #409 I noticed that our GraphiQL hacks to get live schema reloads working were causing errors in GraphiQL version 0.9.3. So this PR fixes the changes and re-pins the GraphiQL version to 0.9.3.

@benjie
Copy link
Member

benjie commented Mar 26, 2017

#407 and #410 are both failing on CI in Node 4 for the same reason:

 FAIL  src/postgraphql/http/__tests__/createPostGraphQLHttpRequestHandler-test.js
  ● Test suite failed to run
    SyntaxError: Unexpected token {
      
      at transformAndBuildScript (node_modules/jest/node_modules/jest-cli/node_modules/jest-runtime/build/transform.js:320:12)
      at Object.<anonymous> (node_modules/koa/lib/application.js:11:18)
      at Object.<anonymous> (src/postgraphql/http/__tests__/createPostGraphQLHttpRequestHandler-test.js:13:11)

@calebmer
Copy link
Collaborator Author

Yeah, I think Koa recently published a release that breaks Node.js 4 (which would be why we haven’t seen it before). master has the fix so I updated the branch 👍

benjie
benjie approved these changes Mar 26, 2017
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the inner workings of GraphiQL, but the changes look sensible, so... 👍

@calebmer calebmer merged commit ef03591 into master Mar 26, 2017
@calebmer calebmer deleted the fix/graphiql branch March 26, 2017 19:29
@calebmer
Copy link
Collaborator Author

Released in 3.1.0 🎉

Belline pushed a commit to Belline/postgraphql that referenced this pull request Dec 18, 2017
@calebmer
fix(graphiql): fix GraphiQL version 0.9.3 integration (graphile#410)
7d8346e
benjie added a commit that referenced this pull request Jan 27, 2020
@benjie
fix(args): allow makeWrapResolversPlugin to override args (#410)
9a70bfa 
Fixes #396
benjie added a commit that referenced this pull request Sep 16, 2023
@benjie
'graphile behavior debug' & fix issue with badly scoped behaviors (#410)
ae2315e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebmer @benjie