Skip to content

MRU Improvements #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stevenyoungs
Copy link
Contributor

When adding new objects, also add them to the MRU list.

For now this is a proof of concept and only adds new people created via the PersonTreeView to the MRU.

In the screen shot below, of the example database, upon loading, Lewis was the active person. I manually clicked Allison followed by Amy. Amy is the active person at this point. I then added two additional people, Aaron and Aaron Jnr.
image

For now, the active person is shown in the MRU list as well. Whilst I initially did this for debug purposes, there is an argument for keeping it.

Related forum discussion starts here: https://gramps.discourse.group/t/add-a-recent-sub-menu/5760/82

self.emit("mru-changed", (self.mru,))
self.index += 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the order in which we emit the mru-changed signal and increment the index of the active object.
I now need to know the currently active object when updating the MRU menu

Is this likely to cause problems elsewhere?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly for Nick's CombinedView and more likely my experimental CardViews which both use a global navigation history object to try to facilitate navigation across different object types in the same view. We had talked about trying to improve the navigation support in Gramps core to better enable and handle things but nothing has been attempted yet and it has been some time since I reviewed what I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants