-
Notifications
You must be signed in to change notification settings - Fork 469
Refactor Relationship Calculator and Add a Searchbar #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Refactor Relationship Calculator and Add a Searchbar #1882
Conversation
Steps to crash the existing relationship calculator tool
An error similar to the below will be generated
In Windows AIO at least, there is a never ending stream of errors. The only escape is to kill the gramps process. |
36bb022
to
10031e4
Compare
5f58ce1
to
cadaa00
Compare
This is framework for future changes
This allows a subclass to set the attributes
- now based on SelectPerson - includes search bar to aid finding the other person - supports changes in active person - handles database change (the previous tool crashes)
cadaa00
to
08f1ba0
Compare
rebased |
I use the Relationship Calculator quite often to the point that I'd really like to see this as a Gramplet if possible, does anybody else feel this way or is it just me? |
Yes, do you have a particular design in mind? Maybe discussing in Discourse would be better. |
Refactor the relationship calculator tool
SelectPerson
previously the calculator had it's own implementation of a person tree
BaseSelector
andSelectPerson
classes updated to support modal or modeless operation. All existing use use remains modalRelated discourse discussion, including user request: https://gramps.discourse.group/t/adding-search-bar-to-select-person-dialog/6845/10?u=stevey