Downgrade spf13/cobra to 1.4.0 #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkiba
requested review from
pablochacin
and removed request for
a team and
pablochacin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To maintain compatibility and continue the integration of
xk6-dashboardwith the main Grafana k6 repository, thespf13/cobradependency downgraded from its current version (v1.9.1) tov1.4.0. This is to align with the version ofspf13/cobracurrently in use by Grafana k6.Problem
The upstream Grafana k6 project uses an older version of the
spf13/cobralibrary (v1.4.0). The current version in this repository (v1.9.1) creates a dependency conflict, which blocks the seamless integration of newerxk6-dashboardversions into Grafana k6.Impact
As a direct consequence of this downgrade, the
szkiba/docsmebuild-time tool, which is used for automatically generating thecmd/k6-web-dashboard/README.mdfile, will no longer be compatible.Therefore, any future updates to the
cmd/k6-web-dashboard/README.mdfile will need to be performed manually. This manual process will remain in effect until thespf13/cobralibrary is updated in the Grafana k6 repository.Additional context
This change is a prerequisite for the feature request in
grafana/k6to enable the web dashboard by default.grafana/k6#4903