Alerting: Fix retryable errors #2304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
titolins
approved these changes
Aug 14, 2025
JacobsonMT
force-pushed
the
jacobsonmt/fix-retryable-errors
branch
from
fb34007 to
b50e117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
orgID = 1restriction forRetryableErrorin all Alerting resourceRetryContexts.Except for the "Alertmanager Not Ready" error, limiting retryability to non-default orgs doesn’t make sense. Even for the default
orgID = 1, retries on "Alertmanager Not Ready" remain valid.Previously, this restriction caused sporadic failures in alerting unit tests, as conflicts between parallel tests for the default org were not retried.
Also switched from the specific
*runtime.APIErrorstruct to the more generalruntime.ClientResponseStatusinterface to accommodate other error types, such asPostContactpointsBadRequest.