-
Notifications
You must be signed in to change notification settings - Fork 263
fix(resource_dashboard): force recreate grafana_dashboard if uid changes #2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Paulo Dias <[email protected]>
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Anyone can review this? |
Hey @paulojmdias! Thank you for sending this PR, I'll take a look! |
Many thanks @radiohead 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! Sorry, I was busy and it took me a while to find time to review this.
Thank you @radiohead! 🙌 I think the failed tests should be related with being a fork branch, but please confirm 🙏 |
Yes, you are correct. I'll get it merged in a bit, since everything works as expected and there aren't any differences in the setup for failing tests, so no need to do anything else from your side. |
Fixes: #2144