Feat: add new alerting rule fields #2120
Conversation
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
|
This depends on fixes for grafana grafana/grafana#103736 and maybe grafana/grafana#103735 |
moustafab
force-pushed
the
moustafab/add-new-rule-fields
branch
2 times, most recently
from
9edb74c to
2d39b0e
Compare
New fields for `keep_firing_for` and `missing_series_evals_to_resolve` have been added to the alerting rule group resource. Added in grafana/grafana#102150
moustafab
force-pushed
the
moustafab/add-new-rule-fields
branch
from
2d39b0e to
96f5843
Compare
Updates to use grafana/grafana-openapi-client-go#113 Not working with the MuteTimings resource, will need to sort a solution for that
|
This became a bit more involved, so converting back to draft while I get the solution for the mute timings. |
| @@ -519,6 +542,15 @@ func packAlertRule(r *models.ProvisionedAlertRule) (interface{}, error) { | |||
| json["record"] = record | |||
| } | |||
|
|
|||
| // FIXME: open api needs to be a reference to the duration | |||
There was a problem hiding this comment.
@alexander-akhmetov I forgot to about this discovery. The For in the spec is a *Duration and the KeepFiringFor is a Duration. I think effectively they're the same thing but not 100% sure, can you have another look at this?
There was a problem hiding this comment.
I'm not sure why it's not a *Duration as well, they are similarly defined. I'll check.
There was a problem hiding this comment.
Probably because the For field is required, it's a pointer: go-swagger/go-swagger#1386 (comment), and KeepFiringFor is not required.
alexander-akhmetov
force-pushed
the
moustafab/add-new-rule-fields
branch
4 times, most recently
from
7b05bf3 to
af63b06
Compare
New fields for
keep_firing_forandmissing_series_evals_to_resolvehave been added to the alerting rule group resource.Added in grafana/grafana#102150