Support for per-zone PDB #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
charleskorn
reviewed
Aug 1, 2025
development/custom-resource-definition-pod-disruption-zone-budget.yaml
Outdated
Show resolved
Hide resolved
development/custom-resource-definition-pod-disruption-zone-budget.yaml
Outdated
Show resolved
Hide resolved
4 tasks
charleskorn
reviewed
Aug 6, 2025
charleskorn
reviewed
Aug 8, 2025
charleskorn
reviewed
Aug 11, 2025
pkg/admission/pod_eviction_test.go
Outdated
Comment on lines
26
to
40
| statefulSetZoneA = "ingester-zone-a" | ||
| statefulSetZoneB = "ingester-zone-b" | ||
| statefulSetZoneC = "ingester-zone-c" | ||
| testPodZoneA0 = "ingester-zone-a-0" | ||
| testPodZoneA1 = "ingester-zone-a-1" | ||
| testPodZoneA2 = "ingester-zone-a-2" | ||
| testPodZoneB0 = "ingester-zone-b-0" | ||
| testPodZoneB1 = "ingester-zone-b-1" | ||
| testPodZoneB2 = "ingester-zone-b-2" | ||
| testPodZoneC0 = "ingester-zone-c-0" | ||
| testPodZoneC1 = "ingester-zone-c-1" | ||
| testPodZoneC2 = "ingester-zone-c-2" | ||
| testNamespace = "test-dev-0" |
There was a problem hiding this comment.
[nit] I'm not sure these constants add much - I'd be inclined to inline them.
charleskorn
reviewed
Aug 13, 2025
Includes; * new web-hook handler for pod eviction added to rollout-operator * manifests for new custom resource definition for configuring the PDBZ * updated development example files and environment
* rename to ZoneAwarePodDisruptionBudget * updated root README * updates to main eviction handler per PR *
* updates per PR review * added ZPDB informer to monitor ZPDB configurations * added Pod informer to work with pod eviction cache * added pod eviction cache * added validating webhook configuration for ZPDB files * added locking for concurrent eviction handling
Modify the rollout-operator to use an informer to monitor for new webhook configurations. Webhook configurations need to be patched with a self signed CA, and previously this was only checked and applied on rollout-operator startup. This change allows for new webhooks to be created once the rollout-operator is running and have the CA patch applied.
…is reporting as running
Modify the rollout-operator to use an informer to monitor for new webhook configurations. Webhook configurations need to be patched with a self signed CA, and previously this was only checked and applied on rollout-operator startup. This change allows for new webhooks to be created once the rollout-operator is running and have the CA patch applied.
…is reporting as running
…com/grafana/rollout-operator into andrewhall-194-support-per-zone-pdb
charleskorn
reviewed
Aug 15, 2025
charleskorn
reviewed
Aug 19, 2025
pkg/zpdb/config.go
Outdated
Comment on lines
60
to
65
| func (c *config) min(a int32, b int32) int32 { | ||
| if a < b { | ||
| return a | ||
| } | ||
| return b | ||
| } |
There was a problem hiding this comment.
Go has a built-in min function that we should be able to use instead of this.
There was a problem hiding this comment.
I found the math.min() which applies to float64 ... is the preference to cast to a float and then back to an int32 or is there another function?
There was a problem hiding this comment.
@tcp13equals2 Charles is referring to the built-in min function, which is generic.
There was a problem hiding this comment.
Ha - nice. Thanks for the tip!
charleskorn
approved these changes
Aug 19, 2025
Update short name for zdpb crd
andyasp
reviewed
Aug 21, 2025
Co-authored-by: Andy Asp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for the implementation of a custom pod disruption budget which is zone and partition aware.
#194
Included in this PR;
Note - this has been tested in mimir-dev-11 in the classic zones configuration draining multiple nodes which span multiple zones + pods.
Note - from a deployment perspective, when this is rolled out to real clusters it is likely it will have to rolled out in 2 phases. Phase 1 would have the updated rollout operator, new CRD, the validating webhook configurations but not the actual new zpdb configuration. This kind relies on the validating webhook to be in-place first, and if this validating webhook has just been added it can be a short wait until it has the CA bundle patched in allowing the endpoint to function. If the zpdb is applied immediately after the validating webhook is added it will fail. So Phase 2 would be rolling out the actual zpdb files which replace the existing pdb file.
Deployment tools libsonnet updates - https://github.com/grafana/deployment_tools/pull/323553
Mimir libsonnet updates - grafana/mimir#12315 (in progress)