-
Notifications
You must be signed in to change notification settings - Fork 706
feat: Make the minStepDuration of the querier configurable per tenant from limits configuration #4540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9c07baf to
72aa99c
Compare
|
I am not sure with the naming of the field, maybe something more clear would be better like seriesMinInterval, what do you think @simonswine ? |
simonswine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR.
I think it would be preferred, if we could configure this a per tenant basis.
For this we typically add a field to the "limit" struct, this has the benefit, that we can change the value on a per tenant basis and also update it without restarting the pyroscope process, here is the related struct:
pyroscope/pkg/validation/limits.go
Line 37 in 5b02fdd
| type Limits struct { |
Let me know if you have any questions
b364e88 to
9d94175
Compare
9d94175 to
930de2f
Compare
|
I applied your suggestions @simonswine |
…limits configuration
03cd455 to
d23c6bb
Compare
|
Hi @simonswine could this be merged anytime soon? Thanks ! |
For issue #4524
Add a way to configure the minInterval in the querier configuration for series graph between each point