Skip to content

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jan 26, 2022

What this PR does:
Refactor cmd/mimir test code to use t.TempDir instead of ioutil.TempFile (deprecated).

Which issue(s) this PR fixes:

Checklist

  • Tests updated
  • [na] Documentation added
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@aknuds1 aknuds1 requested a review from a team January 26, 2022 13:43
@aknuds1 aknuds1 added the chore label Jan 26, 2022
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pracucci pracucci enabled auto-merge (squash) January 26, 2022 13:52
@pracucci pracucci merged commit d96dac8 into main Jan 26, 2022
@pracucci pracucci deleted the chore/refactor-test branch January 26, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants