Skip to content

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Aug 11, 2023

What this PR does / why we need it:

This PR upgrades github.com/grafana/dskit removes Loki's dependency on github.com/weaveworks/common.

The changes in dskit, apart from the migration (grafana/dskit#356), are:

Which issue(s) this PR fixes:

(none)

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • [n/a] Documentation added
  • [n/a] Tests updated
  • [n/a] CHANGELOG.md updated
    • [n/a] If the change is worth mentioning in the release notes, add add-to-release-notes label
  • [n/a] Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • [n/a] For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 11, 2023
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Aug 11, 2023
@charleskorn charleskorn marked this pull request as ready for review August 11, 2023 07:06
@charleskorn charleskorn requested review from JStickler and a team as code owners August 11, 2023 07:06
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this

@MichelHollands MichelHollands merged commit 8e6a543 into main Aug 14, 2023
@MichelHollands MichelHollands deleted the charleskorn/remove-weaveworks-common-dependency branch August 14, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants