Feature toggle: Remove addFieldFromCalculationStatFunctions feature toggle #113757
Conversation
The addFieldFromCalculationStatFunctions feature toggle was at GA stage and enabled by default. This commit removes the toggle and makes the cumulative and window functions permanently available in the add field from calculation transformation. Changes: - Removed feature toggle definition from registry.go - Updated CalculateFieldTransformerEditor to always include cumulative and window functions - Removed unused config import - Removed documentation entry - Regenerated all generated files (toggles_gen.go, toggles_gen.csv, toggles_gen.json, featureToggles.gen.ts)
Develer
requested review from
gelicia and
kylebrandt
and removed request for
a team
github-actions
bot
added
area/backend
area/frontend
type/docs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| | `logsContextDatasourceUi` | Allow datasource to provide custom UI for context view | Yes | | ||
| | `lokiQuerySplitting` | Split large interval queries into subqueries with smaller time intervals | Yes | | ||
| | `influxdbBackendMigration` | Query InfluxDB InfluxQL without the proxy | Yes | | ||
| | `dataplaneFrontendFallback` | Support dataplane contract field name change for transformations and field name matchers where the name is different | Yes | |
Check failure
Code scanning / Vale
Did you really mean 'dataplane'? The Grafana dictionary might not know of this word yet Error documentation
| | `logsExploreTableVisualisation` | A table visualisation for logs in Explore | Yes | | ||
| | `awsDatasourcesTempCredentials` | Support temporary security credentials in AWS plugins for Grafana Cloud customers | Yes | | ||
| | `transformationsRedesign` | Enables the transformations redesign | Yes | | ||
| | `awsAsyncQueryCaching` | Enable caching for async queries for Redshift and Athena. Requires that the datasource has caching and async query support enabled | Yes | |
Check failure
Code scanning / Vale
Did you really mean 'async'? The Grafana dictionary might not know of this word yet Error documentation
| | `logsExploreTableVisualisation` | A table visualisation for logs in Explore | Yes | | ||
| | `awsDatasourcesTempCredentials` | Support temporary security credentials in AWS plugins for Grafana Cloud customers | Yes | | ||
| | `transformationsRedesign` | Enables the transformations redesign | Yes | | ||
| | `awsAsyncQueryCaching` | Enable caching for async queries for Redshift and Athena. Requires that the datasource has caching and async query support enabled | Yes | |
Check failure
Code scanning / Vale
Did you really mean 'async'? The Grafana dictionary might not know of this word yet Error documentation
| | `awsAsyncQueryCaching` | Enable caching for async queries for Redshift and Athena. Requires that the datasource has caching and async query support enabled | Yes | | ||
| | `dashgpt` | Enable AI powered features in dashboards | Yes | | ||
| | `formatString` | Enable format string transformer | Yes | | ||
| | `kubernetesDashboards` | Use the kubernetes API in the frontend for dashboards | Yes | |
Check failure
Code scanning / Vale
Did you really mean 'kubernetes'? The Grafana dictionary might not know of this word yet Error documentation
| | `pinNavItems` | Enables pinning of nav items | Yes | | ||
| | `ssoSettingsLDAP` | Use the new SSO Settings API to configure LDAP | Yes | | ||
| | `cloudWatchRoundUpEndTime` | Round up end time for metric queries to the next minute to avoid missing data | Yes | | ||
| | `newFiltersUI` | Enables new combobox style UI for the Ad hoc filters variable in scenes architecture | Yes | |
Check failure
Code scanning / Vale
Did you really mean 'combobox'? The Grafana dictionary might not know of this word yet Error documentation
| | `dashboardScene` | Enables dashboard rendering using scenes for all roles | Yes | | ||
| | `logsInfiniteScrolling` | Enables infinite scrolling for the Logs panel in Explore and Dashboards | Yes | | ||
| | `logRowsPopoverMenu` | Enable filtering menu displayed when text of a log line is selected | Yes | | ||
| | `alertingQueryOptimization` | Optimizes eligible queries in order to reduce load on datasources | | |
Check warning
Code scanning / Vale
Use 'to' instead of 'in order to'.. For more information, refer to https://grafana.com/docs/writers-toolkit/write/style-guide/word-list/. To fix this, Replace the matched content with one of the following: to. Warning documentation
| | `dashboardScene` | Enables dashboard rendering using scenes for all roles | Yes | | ||
| | `logsInfiniteScrolling` | Enables infinite scrolling for the Logs panel in Explore and Dashboards | Yes | | ||
| | `logRowsPopoverMenu` | Enable filtering menu displayed when text of a log line is selected | Yes | | ||
| | `alertingQueryOptimization` | Optimizes eligible queries in order to reduce load on datasources | | |
Check warning
Code scanning / Vale
Use 'data sources' instead of 'datasources'.. For more information, refer to https://grafana.com/docs/writers-toolkit/write/style-guide/word-list/. To fix this, Replace the matched content with one of the following: data sources. Warning documentation
| | `onPremToCloudMigrations` | Enable the Grafana Migration Assistant, which helps you easily migrate various on-prem resources to your Grafana Cloud stack. | Yes | | ||
| | `groupToNestedTableTransformation` | Enables the group to nested table transformation | Yes | | ||
| | `newPDFRendering` | New implementation for the dashboard-to-PDF rendering | Yes | | ||
| | `tlsMemcached` | Use TLS-enabled memcached in the enterprise caching feature | Yes | |
Check warning
Code scanning / Vale
Use 'Memcached' instead of 'memcached'.. For more information, refer to https://grafana.com/docs/writers-toolkit/write/style-guide/word-list/. To fix this, Replace the matched content with one of the following: Memcached. Warning documentation
| | `pluginsSriChecks` | Enables SRI checks for plugin assets | | | ||
| | `azureMonitorDisableLogLimit` | Disables the log limit restriction for Azure Monitor when true. The limit is enabled by default. | | | ||
| | `alertingUIOptimizeReducer` | Enables removing the reducer from the alerting UI when creating a new alert rule and using instant query | Yes | | ||
| | `azureMonitorEnableUserAuth` | Enables user auth for Azure Monitor datasource only | Yes | |
Check warning
Code scanning / Vale
Use 'data source' instead of 'datasource'.. For more information, refer to https://grafana.com/docs/writers-toolkit/write/style-guide/word-list/. To fix this, Replace the matched content with one of the following: data source. Warning documentation
| | `grafanaAssistantInProfilesDrilldown` | Enables integration with Grafana Assistant in Profiles Drilldown | Yes | | ||
| | `sharingDashboardImage` | Enables image sharing functionality for dashboards | Yes | | ||
| | `tabularNumbers` | Use fixed-width numbers globally in the UI | | | ||
| | `tempoSearchBackendMigration` | Run search queries through the tempo backend | | |
Check warning
Code scanning / Vale
Use 'Tempo' instead of 'tempo'.. For more information, refer to https://grafana.com/docs/writers-toolkit/write/style-guide/word-list/. To fix this, Replace the matched content with one of the following: Tempo. Warning documentation
|
💻 Deploy preview available (Remove addFieldFromCalculationStatFunctions feature toggle): |
Develer
changed the title
alexjonspencer1
left a comment
alexjonspencer1
left a comment
There was a problem hiding this comment.
Optimistically approving, but it's quite hard to read with all of the GitHub alert comments turned on. Can you clean it up and verify the changes one more time on your end?
2 participants
What is this feature?
This PR removes the
addFieldFromCalculationStatFunctionsfeature toggle which was at GA stage and enabled by default.Why is this feature being removed?
The feature toggle has reached General Availability and is enabled by default with
expression: "true". Following the feature toggle lifecycle, GA features that are stable and enabled by default should be removed to reduce technical debt and simplify the codebase.What does this PR change?
pkg/services/featuremgmt/registry.goCalculateFieldTransformerEditor.tsxto always include cumulative and window functions in calculation modesconfigimport from the editor componentImpact
After this change, cumulative and window functions will be permanently available in the "Add field from calculation" transformation. Users will no longer be able to disable this functionality via the feature toggle.
Testing