Skip to content

Scopes: Fix zod schema for scope spec #109348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mdvictor
Copy link
Contributor

@mdvictor mdvictor commented Aug 7, 2025

What is this feature?

Builds on top of this PR. I realized now that the recent scopes no longer show up due to the zod schema being too strict. I am not sure about the contract here, but IIRC the title and description are the only required properties? All the other are optional? Please correct me if I'm wrong.

In any case, this change brings back the recent scopes in the selector as parseScopesFromLocalStorage returns the proper objects from local storage.

Why do we need this feature?

Show recent scopes again.

Who is this feature for?

Everyone

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@mdvictor mdvictor requested a review from a team as a code owner August 7, 2025 14:45
@mdvictor mdvictor added the no-changelog Skip including change in changelog/release notes label Aug 7, 2025
@mdvictor mdvictor closed this Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant