feature: add default spreadsheet ID to config editor #370
+223
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridgepoet
changed the title
Contributor
Author
|
Sorry, merged in #377 but forgot it could be a separate PR (on main instead later). Let me know if you want me to separate it and if I need to redo the changelog. |
yesoreyeram
reviewed
Dec 16, 2025
Comment on lines
154
to
162
| const options = await datasource.getSpreadSheets(); | ||
| const { query } = this.props; | ||
| if (query.spreadsheet) { | ||
| const matchingOption = options.find((opt) => opt.value === query.spreadsheet); | ||
| if (matchingOption && this.state.selectedSheetOption !== matchingOption) { | ||
| this.setState({ selectedSheetOption: matchingOption }); | ||
| } | ||
| } | ||
| return options; |
Contributor
There was a problem hiding this comment.
Seems we are duplicating the code here. Can we extract into function reuse along with updateSelectedSheetOption
Contributor
Author
There was a problem hiding this comment.
Can you check and see if it's what you had in mind?
yesoreyeram
reviewed
Dec 16, 2025
yesoreyeram
reviewed
Dec 16, 2025
yesoreyeram
requested changes
Dec 16, 2025
Contributor
yesoreyeram
left a comment
yesoreyeram
left a comment
There was a problem hiding this comment.
Thanks @fridgepoet . Sorry this took long. Overall LGTM. some nit changes needed for consistency.
Contributor
Author
|
No problem, thanks for having a look @yesoreyeram |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to choose a default spreadsheet ID in the Config Editor.
Once the datasource is saved, the user can use the dropdown menu (similar to the Query Editor) and choose the default query. They do need to save again.
This closes #108