Remove `subscribers_last_week` field from directory API. #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

SiqingYu merged 1 commit into gpodder:master from SiqingYu:remove-subscriber-lastweek

Mar 20, 2020

Contributor

SiqingYu commented Mar 20, 2020

Addressing #375


          Remove subscribers_last_week field from directory API.

d831732

SiqingYu merged commit 8c5df93 into gpodder:master

SiqingYu deleted the remove-subscriber-lastweek branch

March 20, 2020 16:51

Contributor

ByteHamster commented Mar 20, 2020

The XML API needs to be updated, too, I think

Contributor Author

SiqingYu commented Mar 21, 2020

@ByteHamster The OpenAPI YAML spec hasn't specified the fields in the responses yet. No need to update it.

Contributor

ByteHamster commented Mar 21, 2020

I mean this: https://github.com/gpodder/mygpo/blob/1583172764dd8fce74ae443af498291b6adf6df3/mygpo/api/templates/podcasts.xml

In general, if you search for the string, there are some occurrences left: https://github.com/gpodder/mygpo/search?q=subscribers_last_week&type=

The last_subscribers field can probably be removed, here, too: https://github.com/gpodder/mygpo/blob/master/mygpo/api/advanced/directory.py

Contributor Author

SiqingYu commented Mar 22, 2020

@ByteHamster Thanks for your prudent notice. I've removed them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet