Skip to content

Conversation

@zhenghaoz
Copy link
Collaborator

No description provided.

@zhenghaoz zhenghaoz requested a review from Copilot September 24, 2025 12:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds OpenBLAS support as a default BLAS implementation for the Gorse project, providing an alternative to Intel MKL. The changes enable OpenBLAS integration across multiple architectures (amd64, arm64, riscv64) through both Go code modifications and Docker infrastructure.

  • Integrates OpenBLAS as a new BLAS backend with conditional compilation via build tags
  • Creates Docker build infrastructure for OpenBLAS across all Gorse components and architectures
  • Updates build cache configuration from GitHub Actions to Cloudflare R2 storage

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
docker-bake.hcl Renames target from "image" to "openblas" and updates cache configuration to use Cloudflare R2
common/floats/mm_openblas.go New OpenBLAS-specific matrix multiplication implementation with cgo integration
common/floats/mm.go Updates build constraints to exclude OpenBLAS builds
common/floats/floats_*.go Adds OPENBLAS feature flag and integrates it into architecture-specific optimization logic
common/blas/blas_openblas.go New BLAS wrapper for OpenBLAS SGEMM operations
cmd/*/Dockerfile.openblas New Dockerfiles for building each component with OpenBLAS support
cmd/*/Dockerfile.mkl Simplifies MKL Dockerfiles by using golang base image directly

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zhenghaoz zhenghaoz merged commit 9a03d4d into gorse-io:master Sep 24, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant