Connecting to AP with static IP does not seem to work

[sf-jsa]

Bug Description
Using the code provided in Tutorial 6 (connecting as sta) and just extending the RequestNew for the parameters (static_ap, gateway, subnet) does not result in the camera connecting to the access point.

This is the only part of the code that was changed, everything else is exactly the same as the tutorial code:

connect_request = bytearray(
            [
                0x02,  # Feature ID
                0x05,  # Action ID
                *proto.RequestConnectNew(ssid=entry.ssid, password=password,
                                         static_ip=socket.inet_aton('192.168.178.222'),
                                         subnet=socket.inet_aton('255.255.255.0'),
                                         gateway=socket.inet_aton('192.168.178.1'), bypass_eula_check=True).SerializePartialToString(),
            ]
        )

This was tested with a Hero 12 and Hero 13 (both newest firmware).

If the AP has DHCP enabled, the camera connects, ignoring the given static IP values. After DHCP gets disabled we get PROVISIONING_ERROR_FAILED_TO_ASSOCIATE as a result. We also tested several APs with and without Internet connection just to rule that out and since bypass_eula ist only available from 13 onwards.

To Reproduce

1. Use this tutorial
2. Change

connect_request = bytearray(
            [
                0x02,  # Feature ID
                0x05,  # Action ID
                *proto.RequestConnectNew(ssid=entry.ssid, password=password).SerializePartialToString(),
            ]
        )

to (use fitting ip for the tested network)

connect_request = bytearray(
            [
                0x02,  # Feature ID
                0x05,  # Action ID
                *proto.RequestConnectNew(ssid=entry.ssid, password=password,
                                         static_ip=socket.inet_aton('192.168.178.222'),
                                         subnet=socket.inet_aton('255.255.255.0'),
                                         gateway=socket.inet_aton('192.168.178.1'), bypass_eula_check=True).SerializePartialToString(),
            ]
        )

3. Connect to camera and try to connect to AP with static IP

Expected behavior
Camera connects to the AP and has the set static_ip

Hardware

• Camera: Hero12, Hero13 (both cameras have firmware up to date)
• Windows and Linux

Additional context
I am aware that this sounds a bit like this issue, but even with the parameter and newest firmware it does not work.

It seems to us that the cameras are ignoring the additional parameters.

Also cameras got their wireless connection reset several times to try fresh everytime something in the setup got changed.

[Ddezibel]

I'm also quite interested in this functionality. I think it makes sense to have more fine-grained control over the IPs that are assigned to the cameras, because currently it seems a bit random to me. It would help me in having my WiFi IPs a bit more organized, since I'm also using multiple cameras. Would love to have this implemented! :)