[fix] Include git commit hash in tarballs #3124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should allow builds made from a release tarball to accurately display the git commit hash it was built from. It does so by rendering the current short hash when packaging the tarball. This workaround is necessary since the tarball won't include the .git directory so we can't extract the commit information from it. Signed-off-by: Dominik Schulz <[email protected]>
Signed-off-by: Dominik Schulz <[email protected]>
Signed-off-by: Dominik Schulz <[email protected]>
sudoforge
pushed a commit
to sudoforge/gopass
that referenced
this pull request
May 20, 2025
* [fix] Include git commit hash in tarballs This change should allow builds made from a release tarball to accurately display the git commit hash it was built from. It does so by rendering the current short hash when packaging the tarball. This workaround is necessary since the tarball won't include the .git directory so we can't extract the commit information from it. Signed-off-by: Dominik Schulz <[email protected]> * [fix] Fix TestVersionPrinter Signed-off-by: Dominik Schulz <[email protected]> * [fix] Fix spacing Signed-off-by: Dominik Schulz <[email protected]> --------- Signed-off-by: Dominik Schulz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should allow builds made from a release tarball to accurately display the git commit hash it was built from.
It does so by rendering the current short hash when packaging the tarball. This workaround is necessary since the tarball won't include the .git directory so we can't extract the commit information from it.