Restore TTY when aborting TOTP ticker with Ctrl+C #2342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes gopasspw#2320 RELEASE_NOTES=[BUGFIX] Handle Ctrl+C in TOTP Signed-off-by: Dominik Schulz <[email protected]>
|
This makes an tricky code path even more tricky :/ |
|
The failing test looks like a flake to me. |
Signed-off-by: Dominik Schulz <[email protected]>
|
No, it's an actual concurrency issue. |
AnomalRoil
previously approved these changes
Sep 20, 2022
Signed-off-by: Dominik Schulz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2320
RELEASE_NOTES=[BUGFIX] Handle Ctrl+C in TOTP
Signed-off-by: Dominik Schulz [email protected]